Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md for setup of venv and standard pip install #127

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

adhadse
Copy link
Contributor

@adhadse adhadse commented Apr 16, 2022

Resolves #112.
Hey @mattdangerw, This PR is ready for review!
Updated CONTRIBUTING.md file to setup a virtual environment venv and discarding older setup.py develop.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@adhadse adhadse requested a review from mattdangerw April 19, 2022 04:36
@adhadse
Copy link
Contributor Author

adhadse commented Apr 19, 2022

Ready to Merge!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mattdangerw
Copy link
Member

Thanks you!

@mattdangerw mattdangerw merged commit ad47068 into keras-team:master Apr 21, 2022
@adhadse adhadse deleted the setup_fix branch April 23, 2022 13:56
adhadse added a commit to adhadse/keras-nlp that referenced this pull request Sep 17, 2022
…eras-team#127)

* Updated CONTRIBUTING.md for setup of venv and standard pip install

* Updated CONTRIBUTING.md with proposed changes

* Fixes

Co-authored-by: Matt Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants